Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSK-903: do not allow saving changes to project if set to private with no members #2854

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Mar 29, 2023

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/TSK-903

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
ThetaDR Vyacheslav Tumanov
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR changed the title TSK-903: do not allow saving if set to private with no members TSK-903: do not allow saving changes to project if set to private with no members Mar 29, 2023
@haiodo haiodo merged commit 24a4fa3 into main Mar 29, 2023
@haiodo haiodo deleted the TSK-903 branch March 29, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants